[testharness.js] Respect properties.output in assert_wrapper #27320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 26, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2648201
branch
from
2dc2583
to
ef5efc5
Compare
The method was using settings.output to determine if visual output was enabled. It then performed an expensive operation only if it was. However, settings.output is not updated even if 'output' is specified in a call to setup(..) from the testharnessreport.js, as the 'settings' object is meant to outlive different setups (it seems). This change adds an output member to the Tests object, which is initialized from settings.output and then updated by setup(..). We may want a slightly different fix long-term, but this bug is suspected of causing a 33% performance regression on Chromium MSAN bots, so we need something quick! Bug: 1170588 Change-Id: I4d461b846a8cc718d6f8988e5cfec93effa8100a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2648201 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#847028}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2648201
branch
from
ef5efc5
to
0423f87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method was using settings.output to determine if visual output was
enabled. It then performed an expensive operation only if it was.
However, settings.output is not updated even if 'output' is
specified in a call to setup(..) from the testharnessreport.js, as the
'settings' object is meant to outlive different setups (it seems).
This change adds an output member to the Tests object, which is
initialized from settings.output and then updated by setup(..). We
may want a slightly different fix long-term, but this bug is suspected
of causing a 33% performance regression on Chromium MSAN bots, so we
need something quick!
Bug: 1170588
Change-Id: I4d461b846a8cc718d6f8988e5cfec93effa8100a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2648201
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#847028}