Add an internal open pseudo state for <popup> #27399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 29, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2657193
branch
3 times, most recently
from
e107cad
to
723cd65
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2657193
branch
from
723cd65
to
7fc2560
Compare
This approach gives the same end-result as before: popups aren't shown if their 'open' property is false. But with this change, the reason a given popup is visible/invisible will be less magic to developers, because they'll see the UA stylesheet value in devtools. Bug: 1170977 Change-Id: I3368af36631816d8377ab3ba0ea052f2ac1e138a Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2657193 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#849829}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2657193
branch
from
7fc2560
to
c4374a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach gives the same end-result as before: popups aren't
shown if their 'open' property is false. But with this change, the
reason a given popup is visible/invisible will be less magic to
developers, because they'll see the UA stylesheet value in devtools.
Bug: 1170977
Change-Id: I3368af36631816d8377ab3ba0ea052f2ac1e138a
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2657193
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#849829}