Add ref files to WPT tests in css/css-counter-styles (p1) #27471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 4, 2021
This patch mechanically adds ref files to the WPT tests by: - Removing the <meta name='flags' content='font'> tag, since it blocks the test runner from matching the ref file - Add 'list-style-position: inside' so that list markers do not have inline margins, and can match exactly to an inline element - The ref file is a copy of the test file, with all <li> replaced by <div> and list markers replaced by <bdi> with the expected marker content inside Bug: 687225 Change-Id: I386f129441018c8c022ad4d660afecf19a0ae52a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2674491 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#850642}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2674491
branch
from
5f651e1
to
bb121ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch mechanically adds ref files to the WPT tests by:
Removing the <meta name='flags' content='font'> tag, since it blocks
the test runner from matching the ref file
Add 'list-style-position: inside' so that list markers do not have
inline margins, and can match exactly to an inline element
The ref file is a copy of the test file, with all <li> replaced by
<div> and list markers replaced by <bdi> with the expected marker
content inside
Bug: 687225
Change-Id: I386f129441018c8c022ad4d660afecf19a0ae52a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2674491
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#850642}