Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeIO: Add quota to sync Blink interface #27541

Merged
merged 1 commit into from Feb 26, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 9, 2021

This CL adds implements NativeIO's quota management system for
synchronous calls in Blink.

Blink requests capacity from the browser process. This CL does not
change how capacity is granted by the browser process. The IPC call to
the browser for requesting capacity is synchronous if and only if
NativeIO's synchronous interface is being used.

The design doc for NativeIO's quota system is here:
https://docs.google.com/document/d/1wUrtCOsyH3qGwKuqLhV9AJD-bDAjAzfPL5r1GT8H4IY

Bug: 1137788
Change-Id: If306e77bdaa66e34c28a633601608de307875c67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2678951
Commit-Queue: Richard Stotz <rstz@chromium.org>
Auto-Submit: Richard Stotz <rstz@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857916}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2678951 branch 3 times, most recently from 40419b7 to 4448bdc Feb 25, 2021
This CL adds implements NativeIO's quota management system for
synchronous calls in Blink.

Blink requests capacity from the browser process. This CL does not
change how capacity is granted by the browser process. The IPC call to
the browser for requesting capacity is synchronous if and only if
NativeIO's synchronous interface is being used.

The design doc for NativeIO's quota system is here:
https://docs.google.com/document/d/1wUrtCOsyH3qGwKuqLhV9AJD-bDAjAzfPL5r1GT8H4IY

Bug: 1137788
Change-Id: If306e77bdaa66e34c28a633601608de307875c67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2678951
Commit-Queue: Richard Stotz <rstz@chromium.org>
Auto-Submit: Richard Stotz <rstz@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857916}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2678951 branch from 4448bdc to 00b3d5c Feb 26, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 8b759e4 into master Feb 26, 2021
23 checks passed
23 checks passed
@github-actions
update-pr-preview
Details
@azure-pipelines
Azure Pipelines Build #20210226.3 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@staging-wpt-fyi
staging.wpt.fyi - safari[experimental] Safari results
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2678951 branch Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants