Implement CSSOM CSSCounterStyleRule API setters (p2) #27584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 11, 2021
This patch implements the following setters of CSSCounterStyleRule: - system - symbols - additiveSymbols The implementation follows the framework of the previous patch [1], and uses the existing code in CounterStyle to validate the new 'symbols' or 'additive-symbols' values. [1] crrev.com/c/2686322 Bug: 687225 Change-Id: Iab7bed7da902d9f023e623b175e75a458f0f0ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2688521 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#853167}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2688521
branch
from
739c623
to
59c62fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements the following setters of CSSCounterStyleRule:
The implementation follows the framework of the previous patch [1], and
uses the existing code in CounterStyle to validate the new 'symbols' or
'additive-symbols' values.
[1] crrev.com/c/2686322
Bug: 687225
Change-Id: Iab7bed7da902d9f023e623b175e75a458f0f0ce5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2688521
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#853167}