Implement CSSOM CSSCounterStyleRule API name setter #27585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 11, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2689682
branch
from
98f65cf
to
352ef4d
Compare
This is the last patch implementing setters on CSSCounterStyleRule. The name setter is different from the other setters that, changing name may affect cascade result. As a result, we need to re-collect all the @counter-style rules and rebuild the CounterStyleMap. This patch implements it with CSSStyleSheet::RuleMutationScope. Bug: 687225 Change-Id: I369ab9f0e61d5ea3afbbfdd367ff84cc05ebbf58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2689682 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#853209}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2689682
branch
from
352ef4d
to
d425f17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last patch implementing setters on CSSCounterStyleRule.
The name setter is different from the other setters that, changing name
may affect cascade result. As a result, we need to re-collect all the
@counter-style rules and rebuild the CounterStyleMap.
This patch implements it with CSSStyleSheet::RuleMutationScope.
Bug: 687225
Change-Id: I369ab9f0e61d5ea3afbbfdd367ff84cc05ebbf58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2689682
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#853209}