Revert "[TablesNG] Implement column track merging" #27590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2dadda0cccbda46a2fffe23e8c607e88f4d45394. Reason for revert: Suspected cause of paint/tables/huge-table-composited-scroll-collapsed-borders.html failures https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20ASAN/22054 Original change's description: > [TablesNG] Implement column track merging > > One the a11y requirements was that tables should do track merging. > I've skipped implementing this initially because there was major > disagreement about what to do. > > This implementation follows the standard. > Columns defined by TD or COL are merged for table-layout:auto, > and not merged for table-layout:fixed. > > Legacy did not follow the standard for columns defined by TDs: > they were always merged. Firefox implementation was closer to > standard, but sometimes buggy. > > This changes results of some tests. Almost all of them are because > "TablesNG is more standards compliant", and new renderings match > FF. > > There is disagreement about treatment of empty rows between > FF and TablesNGNG. > > external/wpt/css/css-tables/html5-table-formatting-1.html > external/wpt/css/css-tables/html5-table-formatting-2.html > > The rest of the changes render better, just like FF. > > Two new tests have been added: > wpt/css/css-tables/column-track-merging.html > tests the standard. > > accessibility/table-column-track-merging.html > tests Chrome's a11y API. > > Change-Id: Ia222351f7c500963ace556d76c26fcefb1df24e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2670193 > Commit-Queue: Aleks Totic <atotic@chromium.org> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: David Grogan <dgrogan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#852958} TBR=dgrogan@chromium.org,ikilpatrick@chromium.org,atotic@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Id914684949be4eb6196a850bb1168d25872346ef No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2690334 Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#853075}
wpt-pr-bot
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2dadda0cccbda46a2fffe23e8c607e88f4d45394.
Reason for revert: Suspected cause of paint/tables/huge-table-composited-scroll-collapsed-borders.html failures
https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20ASAN/22054
Original change's description:
TBR=dgrogan@chromium.org,ikilpatrick@chromium.org,atotic@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: Id914684949be4eb6196a850bb1168d25872346ef
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2690334
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#853075}