Reland "Add drawImage() and createImageBitmap() support for blink::VideoFrame." #27669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 18, 2021
…deoFrame." This is a reland of 27830868be3b06b19761c7ca4507a8e77ab1f535 - Actual culprit was https://crrev.com/c/2698301 Original change's description: > Add drawImage() and createImageBitmap() support for blink::VideoFrame. > > This makes blink::VideoFrame a CanvasImageSource for drawImage() and > wires up the existing ImageBitmapSource implementation to > createImageBitmap() to deprecate VideoFrame.createImageBitmap(). > > A deprecation notice is added for VideoFrame.createImageBitmap(); the > method will be removed prior to shipping WebCodecs. > > Bug: 1175907 > Test: New (moved from internal) WPT tests. > > Change-Id: I549d996c9b16a8d0a1dd5293b5bee29f61cac8f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2680955 > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#854938} Bug: 1175907 Change-Id: Iecd29b081b9fd70e31836fdace7b0c9f4ab60aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702518 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Reviewed-by: Fernando Serboncini <fserb@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#855343}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2702518
branch
from
f349318
to
dc982c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of 27830868be3b06b19761c7ca4507a8e77ab1f535 - Actual
culprit was https://crrev.com/c/2698301
Original change's description:
Bug: 1175907
Change-Id: Iecd29b081b9fd70e31836fdace7b0c9f4ab60aca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2702518
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#855343}