Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLPattern: Add wildcard '*' support. #27679

Merged
merged 1 commit into from Feb 24, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 18, 2021

This CL adds support for a wildcard * character in patterns. It is
treated as being equivalent to the (.*) unnamed regexp group. This
means it can have its own following modifiers like *? which can affect
how prefix characters are treated. For example, /foo/*? will match
/foo but /foo/* will not.

This CL deviates from the current upstream path-to-regexp v6.2.0, but
we plan to upstream this change. Initial discussions suggest that its
possible this will be accepted.

Bug: 1141510
Change-Id: I386b03e8bb05aab9586464986faf002e824e189e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2673887
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856942}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2673887 branch 3 times, most recently from 90978eb to b9e8f69 Feb 22, 2021
This CL adds support for a wildcard `*` character in patterns.  It is
treated as being equivalent to the `(.*)` unnamed regexp group.  This
means it can have its own following modifiers like `*?` which can affect
how prefix characters are treated.  For example, `/foo/*?` will match
`/foo` but `/foo/*` will not.

This CL deviates from the current upstream path-to-regexp v6.2.0, but
we plan to upstream this change.  Initial discussions suggest that its
possible this will be accepted.

Bug: 1141510
Change-Id: I386b03e8bb05aab9586464986faf002e824e189e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2673887
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856942}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2673887 branch from b9e8f69 to ded540a Feb 24, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 63a13ac into master Feb 24, 2021
23 checks passed
23 checks passed
update-pr-preview
Details
Azure Pipelines Build #20210224.4 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2673887 branch Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants