[markers] Fix crash with negative available-size. #27945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 8, 2021
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2743418
branch
from
db98f3d
to
93e2f6c
Compare
Previously code in NGUnpositionedListMarker was able to produce an available_size < 0, which triggered a DCHECK in the NGBfcRect. This switches the calculation to the available-size on the container builder. Bug: 1183869 Change-Id: I61f6d95c8edbe14b71fd7577e73b287ed5e4f038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2743418 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#861025}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2743418
branch
from
93e2f6c
to
d9bdf24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously code in NGUnpositionedListMarker was able to produce an
available_size < 0, which triggered a DCHECK in the NGBfcRect.
This switches the calculation to the available-size on the
container builder.
Bug: 1183869
Change-Id: I61f6d95c8edbe14b71fd7577e73b287ed5e4f038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2743418
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#861025}