v8bindings: Enable the fix of cross origin window name visibility #27956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 9, 2021
Enables the fix of cross origin window name visibility in production. This fix was once applied back in 2017, but got reverted due to a bug in youtube.com (not because the fix was wrong). We've been disabling the fix since then. The bug in youtube.com was fixed many years ago, so nothing should prevent us to enable the fix now. https://chromestatus.com/metrics/feature/timeline/popularity/1872 shows the affected cases of this fix as 0.045% of page loads. So, we shouldn't hit the same severe trouble like the one of youtube.com in the past. Bug: 538562 Change-Id: Ia28090493c2eb1f67d65de52f64690bb755ed38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2734200 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#861825}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2734200
branch
from
bb6ffa0
to
f58bd2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the fix of cross origin window name visibility in
production.
This fix was once applied back in 2017, but got reverted due to
a bug in youtube.com (not because the fix was wrong). We've been
disabling the fix since then. The bug in youtube.com was fixed
many years ago, so nothing should prevent us to enable the fix now.
https://chromestatus.com/metrics/feature/timeline/popularity/1872
shows the affected cases of this fix as 0.045% of page loads.
So, we shouldn't hit the same severe trouble like the one of
youtube.com in the past.
Bug: 538562
Change-Id: Ia28090493c2eb1f67d65de52f64690bb755ed38a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2734200
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#861825}