[Gecko Bug 1696437] Annotate more Android+nnt tests. #27996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dialog-form-submission was hitting a rounding error because of a weird DPI caused by the viewport scaling. The rest are simple annotation tweaks. Differential Revision: https://phabricator.services.mozilla.com/D107229 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1696437 gecko-commit: 3a4b4661752253afaf0aa85c4cd54ede814431c4 gecko-reviewers: mstange
The file button inherits the font-size of the file input, so that needs fixing. Related HTML spec PR: whatwg/html#6447 The checkbox baseline was also the other thing that was wrong, and that allows us to remove the sketchy allowedDelta. Differential Revision: https://phabricator.services.mozilla.com/D107230 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1696437 gecko-commit: c45afb640afd776a36a4ec19fe31c49269f31642 gecko-reviewers: mstange
wpt-pr-bot
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dialog-form-submission was hitting a rounding error because of a weird
DPI caused by the viewport scaling. The rest are simple annotation tweaks.
Differential Revision: https://phabricator.services.mozilla.com/D107229
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1696437
gecko-commit: 3a4b4661752253afaf0aa85c4cd54ede814431c4
gecko-reviewers: mstange