webcodecs: Temporal SVC encode #28063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 12, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2755947
branch
2 times, most recently
from
529e12d
to
42f2176
Compare
1. Adding VideoEncoderConfig.scalabilityMode and EncodedVideoChunkMetadata 2. Connecting them to SVC fields in media::VideoEncoder config and output 3. Renaming VideoEncoderOutputCallback to EncodedVideoChunkOutputCallback in order to comply with the spec. 4. Deleting EncodedVideoMetadata, it doesn't do anything, and can be confused with EncodedVideoChunkMetadata 5. New test: temporal_svc.any.js Bug: 1176474 Change-Id: Ia89ec093c55df4495f50d51262bcc75c578fd8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2755947 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#863171}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2755947
branch
from
42f2176
to
3a2f55c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to comply with the spec.
and can be confused with EncodedVideoChunkMetadata
Bug: 1176474
Change-Id: Ia89ec093c55df4495f50d51262bcc75c578fd8d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2755947
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#863171}