Add FileSystemHandle::Remove method #28087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 15, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2732700
branch
from
dccbcce
to
378997b
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2732700
branch
4 times, most recently
from
2648a2f
to
3409c64
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2732700
branch
from
3409c64
to
50069db
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2732700
branch
3 times, most recently
from
8e67390
to
dbcb805
Compare
Currently, it is not possible to remove a file or directory given its handle. You must obtain the handle of the parent directory and call FileSystemDirectoryHandle::RemoveEntry. This CL allows for the removal of a file or directory from the local file system without needing the handle of its parent. Bug: 1114923 Change-Id: I1db1ef54e6c3a15069a3b8afa100b34f3f912e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2732700 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#896704}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2732700
branch
from
dbcb805
to
6769915
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is not possible to remove a file or directory given its
handle. You must obtain the handle of the parent directory and call
FileSystemDirectoryHandle::RemoveEntry.
This CL allows for the removal of a file or directory from the local
file system without needing the handle of its parent.
Bug: 1114923
Change-Id: I1db1ef54e6c3a15069a3b8afa100b34f3f912e00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2732700
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/master@{#896704}