Fix painting of composited overflow controls with visibility:hidden #28090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 15, 2021
We can have a composited scroller with visibility:hidden if it has visibility:visible descendants. We should skip painting of overflow controls in the case. Ideally we should not create composited overflow control layers, but I would not touch the pre-CompositeAfterPaint code for the rare case. Bug: 1187818, 1185968 Change-Id: If59049a685fa153b6538f8ca2424792904096000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2761470 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#863011}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2761470
branch
from
2ba20d2
to
c220898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can have a composited scroller with visibility:hidden if it has
visibility:visible descendants. We should skip painting of overflow
controls in the case. Ideally we should not create composited
overflow control layers, but I would not touch the
pre-CompositeAfterPaint code for the rare case.
Bug: 1187818, 1185968
Change-Id: If59049a685fa153b6538f8ca2424792904096000
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2761470
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#863011}