Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate COOP in PolicyContainer #28128

Merged
merged 1 commit into from May 4, 2021
Merged

Integrate COOP in PolicyContainer #28128

merged 1 commit into from May 4, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 18, 2021

This adds Cross-Origin Opener Policy to the policy container.
This was previously within [1], which was then split into COOP and COEP
specific CLs.
With this COOP inheritance is handled by the PolicyContainer.
PolicyContainer does not handle the inheritance from the opener during
a new window creation, given that COOP inheritance differs significantly:

  • It inherits from the top frame of the opener, if the opener is
    same-origin with its top frame.
    Further details in [2].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2490046/.
[2] https://docs.google.com/document/d/1CnG8IWCXencWxmsQMDt9JHUucfpbWXjgknRjquzquV0/edit#

Bug: 1153648
Change-Id: I77bb56bb0d6cd5c8f1523c14487817e970cb0bd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565243
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Cr-Commit-Position: refs/heads/master@{#877388}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2565243 branch 10 times, most recently from 4284a90 to 53cfdc9 Mar 25, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2565243 branch 9 times, most recently from 3edc152 to a84cc2b Apr 22, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2565243 branch 3 times, most recently from e21572e to fcadaaf Apr 29, 2021
This adds Cross-Origin Opener Policy to the policy container.
This was previously within [1], which was then split into COOP and COEP
specific CLs.
With this COOP inheritance is handled by the PolicyContainer.
PolicyContainer does not handle the inheritance from the opener during
a new window creation, given that COOP inheritance differs significantly:
 - It inherits from the top frame of the opener, if the opener is
same-origin with its top frame.
Further details in [2].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2490046/.
[2] https://docs.google.com/document/d/1CnG8IWCXencWxmsQMDt9JHUucfpbWXjgknRjquzquV0/edit#

Bug: 1153648
Change-Id: I77bb56bb0d6cd5c8f1523c14487817e970cb0bd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565243
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Cr-Commit-Position: refs/heads/master@{#877388}
@jpchase
Copy link

@jpchase jpchase commented May 4, 2021

The changed tests are flaky on both Chrome Dev and Firefox nightly (this could be new or pre-existing flakes).

Chrome Dev unstable results

Test Subtest Results Messages
/html/cross-origin-opener-policy/navigate-to-aboutblank.https.html   CRASH: 3/10, OK: 7/10  
/html/cross-origin-opener-policy/navigate-to-aboutblank.https.html Navigate to about:blank from iframe with opener.top COOP: |header(Cross-Origin-Opener-Policy,same-origin), iframe origin: https://web-platform.test:8443, openee COOP: |header(Cross-Origin-Opener-Policy,same-origin), openee origin: https://web-platform.test:8443. PASS: 7/10, MISSING: 3/10  
/html/cross-origin-opener-policy/navigate-to-aboutblank.https.html Navigate to about:blank from iframe with opener.top COOP: |header(Cross-Origin-Opener-Policy,same-origin)|header(Cross-Origin-Embedder-Policy,require-corp), iframe origin: https://web-platform.test:8443, openee COOP: |header(Cross-Origin-Opener-Policy,same-origin)|header(Cross-Origin-Embedder-Policy,require-corp), openee origin: https://web-platform.test:8443. PASS: 7/10, MISSING: 3/10  
/html/cross-origin-opener-policy/navigate-to-aboutblank.https.html Navigate to about:blank from iframe with opener.top COOP: |header(Cross-Origin-Opener-Policy,same-origin-allow-popups), iframe origin: https://web-platform.test:8443, openee COOP: |header(Cross-Origin-Opener-Policy,same-origin-allow-popups), openee origin: https://web-platform.test:8443. PASS: 7/10, MISSING: 3/10  
/html/cross-origin-opener-policy/navigate-to-aboutblank.https.html Navigate to about:blank from iframe with opener.top COOP: |header(Cross-Origin-Opener-Policy,same-origin-allow-popups), iframe origin: https://web-platform.test:8443, openee COOP: |header(Cross-Origin-Opener-Policy,unsafe-none), openee origin: https://www1.web-platform.test:8443. FAIL: 7/10, MISSING: 3/10 assert_equals: expected "true" but got "false"
/html/cross-origin-opener-policy/navigate-to-aboutblank.https.html Navigate to about:blank from iframe with opener.top COOP: |header(Cross-Origin-Opener-Policy,same-origin-allow-popups), iframe origin: https://www1.web-platform.test:8443, openee COOP: |header(Cross-Origin-Opener-Policy,unsafe-none), openee origin: https://www1.web-platform.test:8443. PASS: 7/10, MISSING: 3/10  
/html/cross-origin-opener-policy/navigate-top-to-aboutblank.https.html   CRASH: 1/10, OK: 9/10  
/html/cross-origin-opener-policy/navigate-top-to-aboutblank.https.html Navigate top to about:blank from iframe with opener COOP: |header(Cross-Origin-Opener-Policy,same-origin), iframe origin: https://web-platform.test:8443 FAIL: 9/10, MISSING: 1/10 assert_equals: expected "about:blank loaded" but got "about:blank NOT loaded"
/html/cross-origin-opener-policy/navigate-top-to-aboutblank.https.html Navigate top to about:blank from iframe with opener COOP: |header(Cross-Origin-Opener-Policy,same-origin), iframe origin: https://www1.web-platform.test:8443 FAIL: 9/10, MISSING: 1/10 assert_equals: expected "about:blank loaded" but got "about:blank NOT loaded"
/html/cross-origin-opener-policy/navigate-top-to-aboutblank.https.html Navigate top to about:blank from iframe with opener COOP: |header(Cross-Origin-Opener-Policy,same-origin-allow-popups), iframe origin: https://www1.web-platform.test:8443 FAIL: 9/10, MISSING: 1/10 assert_equals: expected "about:blank loaded" but got "about:blank NOT loaded"

Firefox Nightly unstable results

Test Subtest Results Messages
/html/cross-origin-opener-policy/navigate-top-to-aboutblank.https.html CRASH: 3/10, OK: 6/10, TIMEOUT: 1/10
/html/cross-origin-opener-policy/navigate-top-to-aboutblank.https.html Navigate top to about:blank from iframe with opener COOP: |header(Cross-Origin-Opener-Policy,same-origin), iframe origin: https://web-platform.test:8443 FAIL: 6/10, MISSING: 4/10 assert_equals: expected "about:blank loaded" but got "about:blank NOT loaded"
/html/cross-origin-opener-policy/navigate-top-to-aboutblank.https.html Navigate top to about:blank from iframe with opener COOP: |header(Cross-Origin-Opener-Policy,same-origin), iframe origin: https://www1.web-platform.test:8443 FAIL: 6/10, MISSING: 4/10 assert_equals: expected "about:blank loaded" but got "about:blank NOT loaded"
/html/cross-origin-opener-policy/navigate-top-to-aboutblank.https.html Navigate top to about:blank from iframe with opener COOP: |header(Cross-Origin-Opener-Policy,same-origin-allow-popups), iframe origin: https://www1.web-platform.test:8443 FAIL: 6/10, MISSING: 4/10 assert_equals: expected "about:blank loaded" but got "about:blank NOT loaded"

@jpchase
Copy link

@jpchase jpchase commented May 4, 2021

Filed crbug.com/1205423. I'll force merge this PR for now.

@jpchase jpchase merged commit a8725b3 into master May 4, 2021
20 of 23 checks passed
@jpchase jpchase deleted the chromium-export-cl-2565243 branch May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants