URLPattern: Revamp baseURL second argument approach. #28252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 25, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2785414
branch
from
be3a0ad
to
2f2440a
Compare
This CL revamps our approach to using a second argument for baseURL. The changes include: * Using a union type in the webidl so we can throw an informative exception instead of silently coercing an object to a string that always fails. * Exposing the original input values in `URLPatternResult.inputs`. The old `input` property is now accessed as `inputs[0]`. * WPT test harness uses `inputs` to determine what to pass to `test()` and `exec()`. This replaces the old `input` and `inputBaseURL` properties. * WPT test harness automatically validates the result `inputs` matches the argument `inputs`. Many duplicative `input` lines are removed as they are no longer needed. * WPT test allows `expected_match: 'error'` to indicate that `test()` and `exec()` are expected to throw TypeError exceptions. * WPT test removes `error: true` in favor of `expected_obj: 'error'` in order to match the behavior above for match errors. Bug: 1141510 Change-Id: I3574393a965678595dd67d59931f9ec72338f346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2785414 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#867723}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2785414
branch
from
2f2440a
to
c6b4506
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL revamps our approach to using a second argument for baseURL.
The changes include:
exception instead of silently coercing an object to a string that
always fails.
URLPatternResult.inputs. Theold
inputproperty is now accessed asinputs[0].inputsto determine what to pass totest()and
exec(). This replaces the oldinputandinputBaseURLproperties.
inputsmatchesthe argument
inputs. Many duplicativeinputlines are removedas they are no longer needed.
expected_match: 'error'to indicate thattest()and
exec()are expected to throw TypeError exceptions.error: truein favor ofexpected_obj: 'error'inorder to match the behavior above for match errors.
Bug: 1141510
Change-Id: I3574393a965678595dd67d59931f9ec72338f346
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2785414
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#867723}