Revert "Relax constraints on scroll snapping for snap-type both." #28331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9f51ed46d53717149e7496dbd7baf0eb372c046a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 868394 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzlmNTFlZDQ2ZDUzNzE3MTQ5ZTc0OTZkYmQ3YmFmMGViMzcyYzA0NmEM Original change's description: > Relax constraints on scroll snapping for snap-type both. > > Our scroll snapping logic confined the snap position to be within > the visible snapport if snapping in both the x and y direction; however, > snaps are allowed to be outside the "snapport's search corridor" as long > as they are not too far outside (left to the user agent to determine > what constitutes "too far"). The relaxed rules are not applied if > snapping in one direction only, or if scroll-snap-stop is set to > 'always'. > > In addressing the issue, two other tests required tweaking since they > had no allowance for a 2D snap outside the visible snapport either > implicitly (nested-scrollIntoView-snaps.html) or explicitly > (scroll_snap_data_unittest.cc). > > Bug: 626703 > Change-Id: I3646ccc271d88e06f3e6655009e32ff2a9e08931 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2785142 > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Kevin Ellis <kevers@chromium.org> > Cr-Commit-Position: refs/heads/master@{#868394} Bug: 626703 Change-Id: I760ad79c204f0f3dc7d73a5fd721b1bf91a2d827 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2798148 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#868436}
wpt-pr-bot
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9f51ed46d53717149e7496dbd7baf0eb372c046a.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified CL at revision 868394 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzlmNTFlZDQ2ZDUzNzE3MTQ5ZTc0OTZkYmQ3YmFmMGViMzcyYzA0NmEM
Original change's description:
Bug: 626703
Change-Id: I760ad79c204f0f3dc7d73a5fd721b1bf91a2d827
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2798148
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Noel Gordon <noel@chromium.org>
Auto-Submit: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#868436}