Revert "webcodecs: Stop closing frames in Audio|VideoEncoder.encode()" #28367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 477ea10ee350777a599a4541b6e436ec42563597. Reason for revert: It looks like this CL is responsible for breaking the step "blink_web_tests" on the builder "WebKit Linux MSAN". First failing build: https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20MSAN/9927 Original change's description: > webcodecs: Stop closing frames in Audio|VideoEncoder.encode() > > Change-Id: I0281c1bdd836a94f968bf8fdf4fe8d09392845c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2803617 > Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Commit-Queue: Eugene Zemtsov <eugene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#869112} Change-Id: Iacb9e31ff575129a7b320954a5d65dfaf6274b19 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2805814 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Fabian Sommer <fabiansommer@chromium.org> Auto-Submit: Fabian Sommer <fabiansommer@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#869156}
wpt-pr-bot
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 477ea10ee350777a599a4541b6e436ec42563597.
Reason for revert:
It looks like this CL is responsible for breaking the step
"blink_web_tests" on the builder "WebKit Linux MSAN".
First failing build:
https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20MSAN/9927
Original change's description:
Change-Id: Iacb9e31ff575129a7b320954a5d65dfaf6274b19
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2805814
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Fabian Sommer <fabiansommer@chromium.org>
Auto-Submit: Fabian Sommer <fabiansommer@chromium.org>
Commit-Queue: Fabian Sommer <fabiansommer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869156}