Consume whitespace after nested compound argument #28542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 16, 2021
Currently :host(:is(div )) does not parse, but :is(:is(div )) does. This is because ConsumeComplexSelector cleans up trailing whitespace (effectively), but ConsumeCompoundSelector doesn't. Fixed: 1199653 Change-Id: I4fe52cfee1b5ef0fbde229b2ec7efb38740ed268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2831652 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#873310}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2831652
branch
from
d6c50a9
to
00b165e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently :host(:is(div )) does not parse, but :is(:is(div )) does.
This is because ConsumeComplexSelector cleans up trailing whitespace
(effectively), but ConsumeCompoundSelector doesn't.
Fixed: 1199653
Change-Id: I4fe52cfee1b5ef0fbde229b2ec7efb38740ed268
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2831652
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#873310}