Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebCodecs] Fix issues when reset() happens during flush(). #28609

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 21, 2021

reset() clears the active configuration, so we should not attempt
to reinitialize if reset() was called during flush().

R=eugene

Fixed: 1200768
Change-Id: Iac34480ba859ab156d6a93c943a7ffce9304b1ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2842784
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Reviewed-by: Eugene Zemtsov <eugene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874546}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

reset() clears the active configuration, so we should not attempt
to reinitialize if reset() was called during flush().

R=eugene

Fixed: 1200768
Change-Id: Iac34480ba859ab156d6a93c943a7ffce9304b1ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2842784
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Reviewed-by: Eugene Zemtsov <eugene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874546}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants