Don't fragment clipped overflow. #28620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 21, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2843465
branch
from
30b3d2e
to
379cb07
Compare
When a node clips block-axis overflow, do not insert any further breaks when reaching the block-end of the node. We don't want it to cause generation of superfluous fragmentainers whose only purpose is to hold a zero-size clipped fragment. This introduces another reason for aborting and re-running layout, somewhat similar to the early-break mechanism that we already have (which is involved when we run out of fragmentainer space at a less than ideal location). Bug: 1066616, 829028 Change-Id: Ic2f1082319513a7f24cbe114eb93ebdb75c97bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2843465 Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#875622}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2843465
branch
from
379cb07
to
f8efe04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a node clips block-axis overflow, do not insert any further breaks
when reaching the block-end of the node. We don't want it to cause
generation of superfluous fragmentainers whose only purpose is to hold a
zero-size clipped fragment.
This introduces another reason for aborting and re-running layout,
somewhat similar to the early-break mechanism that we already have
(which is involved when we run out of fragmentainer space at a less than
ideal location).
Bug: 1066616, 829028
Change-Id: Ic2f1082319513a7f24cbe114eb93ebdb75c97bfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2843465
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#875622}