Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove feature-policy/ directory #28689

Closed
wants to merge 1 commit into from
Closed

Remove feature-policy/ directory #28689

wants to merge 1 commit into from

Conversation

foolip
Copy link
Member

@foolip foolip commented Apr 26, 2021

The directory was copied to permissions-policy/ in #25846.

The changes in feature-policy/ since then have been:

These changes were either done in both directories, except for #26748
which was a removal of files from feature-policy/ only.

@foolip
Remove feature-policy/ directory
ea2a458 
The directory was copied to permissions-policy/ in #25846.

The changes in feature-policy/ since then have been:
 - #25841
 - #26382
 - #26459
 - #26748

These changes were either done in both directories, except for #26748
which was a removal of files from feature-policy/ only.
foolip added a commit that referenced this pull request Apr 26, 2021
@foolip
Fix HTMLIframeElement capitalization typos
6327aea 
Remove feature-policy/idlharness.window.js since it was an exact
duplicate of permissions-policy/idlharness.window.js.

See also #28689.
@foolip foolip mentioned this pull request Apr 26, 2021
Merged
@foolip
Copy link
Member Author

foolip commented Apr 26, 2021

@clelland I don't know if the plan was to remove this little by little, but I spotted one exactly duplicated test in #28690 so I'm sending this to ask if there's more that should just be removed.

foolip added a commit that referenced this pull request Apr 26, 2021
@foolip
Fix HTMLIframeElement capitalization typos (#28690)
6dbdb9e 
Remove feature-policy/idlharness.window.js since it was an exact
duplicate of permissions-policy/idlharness.window.js.

See also #28689.
@clelland
Copy link
Contributor

clelland commented May 6, 2021

I don't know if the plan was to remove this little by little

Yes, on the Chromium side, the rename and test replacement has been done in stages. At the time that we did this, it looked like a rename of document.featurePolicy to document.permissionsPolicy was an obvious and imminent move, but at the same time, we didn't want to lose test coverage of the existing mechanism (You can see that there are several test failures in permissions-policy which pass in feature-policy, because of that rename.)

I think that the best course here is to delete this directory, and to also replace the unimplemented document.permissionsPolicy in https://github.com/web-platform-tests/wpt/blob/master/permissions-policy/resources/permissions-policy.js with the currently un-specced, but implemented-and-working document.featurePolicy.

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 8, 2021
@foolip @moz-wptsync-bot
Bug 1707565 [wpt PR 28690] - Fix HTMLIframeElement capitalization typ…
055667a 
…os, a=testonly

Automatic update from web-platform-tests
Fix HTMLIframeElement capitalization typos (#28690)

Remove feature-policy/idlharness.window.js since it was an exact
duplicate of permissions-policy/idlharness.window.js.

See also web-platform-tests/wpt#28689.
--

wpt-commits: 6dbdb9e653249cb130b73a2644d6000c37731549
wpt-pr: 28690
@moz-wptsync-bot moz-wptsync-bot mentioned this pull request Jul 25, 2021
Merged
moz-wptsync-bot pushed a commit that referenced this pull request Jul 25, 2021
@karlt @moz-wptsync-bot
use permissions-policy.js instead of feature-policy.js for display-ca…
5ca00d1 
…pture

See also #28689

Depends on D119598

Differential Revision: https://phabricator.services.mozilla.com/D119599

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1597285
gecko-commit: a714aa598706c0e54850813a549aa03ed402e98f
gecko-reviewers: jib
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 26, 2021
@karlt
Bug 1597285 use permissions-policy.js instead of feature-policy.js fo…
275b62c 
…r display-capture r=jib

See also web-platform-tests/wpt#28689

Depends on D119598

Differential Revision: https://phabricator.services.mozilla.com/D119599
moz-wptsync-bot pushed a commit that referenced this pull request Jul 27, 2021
@karlt @moz-wptsync-bot
use permissions-policy.js instead of feature-policy.js for display-ca…
b68759f 
…pture

See also #28689

Depends on D119598

Differential Revision: https://phabricator.services.mozilla.com/D119599

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1597285
gecko-commit: a714aa598706c0e54850813a549aa03ed402e98f
gecko-reviewers: jib
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Jul 27, 2021
@karlt
Bug 1597285 use permissions-policy.js instead of feature-policy.js fo…
4fb89f8 
…r display-capture r=jib

See also web-platform-tests/wpt#28689

Depends on D119598

Differential Revision: https://phabricator.services.mozilla.com/D119599
@foolip
Copy link
Member Author

foolip commented Sep 10, 2021

@clelland are you still planning to do this rename/cleanup on the Chromium side?

@foolip foolip closed this Oct 11, 2022
@foolip foolip deleted the foolip/rm-feature-policy branch October 11, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakulf bakulf Awaiting requested review from bakulf

@clelland clelland Awaiting requested review from clelland

Assignees

@clelland clelland

Labels
feature-policy wg-webappsec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@foolip @clelland @wpt-pr-bot