Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of six.integer_types/string_types/text_type #28789

Merged
merged 1 commit into from May 10, 2021

Commits on May 6, 2021

  1. Remove use of six.integer_types/string_types/text_type

    These are constants corresponding to just int/str/str in Python 3:
    https://six.readthedocs.io/#constants
    
    This is simple search-replace with the exception of
    resources/test/conftest.py, where element.text is already a string. If
    it were None or bytes, then JSON parsing would fail anyway.
    
    In service-workers/cache-storage/resources/vary.py, the reason why
    str(cookie_vary) works was non-obvious. Correct the documentation in
    tools/wptserve/wptserve/request.py to show that the cookie_vary value
    would be a CookieValue, not a binary string.
    
    Since no use of six remains in tools/wptserve/, it's removed as a
    dependency in wptserve's setup.py.
    
    Part of #28776.
    foolip committed May 6, 2021
    Copy the full SHA
    89be305 View commit details
    Browse the repository at this point in the history