Reland "[TablesNG] Fix OOF static-position of empty baseline-aligned table-cells" #28943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 10, 2021
…table-cells" This is a reland of 75216ac41d2da077f3ae3a0ca992ee3e03a937a8 This was reverted in: https://chromium-review.googlesource.com/c/chromium/src/+/2882605 "Reason for revert: Suspected to cause layout test failure on mac11" However these were pre-existing layout test failures, and were present on the mac11 bot after reverting, see: https://ci.chromium.org/p/chromium/builders/ci/Mac11%20Tests/668 Original change's description: > [TablesNG] Fix OOF static-position of empty baseline-aligned table-cells > > Alignment typically does affect the static-position of any > OOF-positioned children inside of a table-cell. However when we are > baseline-aligned, we should only apply the adjustment if we have > *inflow* children. > > This doesn't shift the OOF-positioned children if we have no inflow > children. > > Bug: 1206654 > Change-Id: I54e80831148407797354157d2c0d19afbb2a7858 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2880809 > Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Aleks Totic <atotic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#880652} Bug: 1206654 Change-Id: Ic232f57b8feba0112693385bb2ca90d7cc8164ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2883187 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#881069}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2883187
branch
from
84ed704
to
4e2fe3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of 75216ac41d2da077f3ae3a0ca992ee3e03a937a8
This was reverted in:
https://chromium-review.googlesource.com/c/chromium/src/+/2882605
"Reason for revert: Suspected to cause layout test failure on mac11"
However these were pre-existing layout test failures, and were present
on the mac11 bot after reverting, see:
https://ci.chromium.org/p/chromium/builders/ci/Mac11%20Tests/668
Original change's description:
Bug: 1206654
Change-Id: Ic232f57b8feba0112693385bb2ca90d7cc8164ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2883187
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881069}