Allow mouse drag from inside a <popup> to outside #28966
Merged
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 12, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2890150
branch
from
3149074
to
e61fe0d
Compare
With this CL, mousing-down inside a <popup> and dragging to outside that <popup> will no longer light-dismiss the popup. This also changes the trigger for light dismiss from "click" to "mousedown", which mirrors platform conventions. Bug: 1168738 Change-Id: I23aa035107409b9fb2f36ee90ef8a3c08d8e0c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2890150 Commit-Queue: Mason Freed <masonf@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#882881}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2890150
branch
from
e61fe0d
to
1ec3df0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this CL, mousing-down inside a <popup> and dragging to outside
that <popup> will no longer light-dismiss the popup. This also changes
the trigger for light dismiss from "click" to "mousedown", which
mirrors platform conventions.
Bug: 1168738
Change-Id: I23aa035107409b9fb2f36ee90ef8a3c08d8e0c62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2890150
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#882881}