[css-flex] Make initial block-size indefinite in column flex in min/max. #28991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 13, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2878647
branch
from
836c343
to
777ad18
Compare
This changes the behaviour of ComputeMinMaxSizes within a column flexbox. Previously we'd allow the initial block-size of a child to resolve, allowing grandchildren to size against that definite block-size. This change the behaviour to act more like the "measure" phase within column flexboxes, e.g. the initial block-size for children is indefinite. Change-Id: I84ac87b1976d4eba95d9efe2e53e92b657e044a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2878647 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#882716}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2878647
branch
from
777ad18
to
c4003c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behaviour of ComputeMinMaxSizes within a column flexbox.
Previously we'd allow the initial block-size of a child to resolve,
allowing grandchildren to size against that definite block-size.
This change the behaviour to act more like the "measure" phase within
column flexboxes, e.g. the initial block-size for children is indefinite.
Change-Id: I84ac87b1976d4eba95d9efe2e53e92b657e044a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2878647
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#882716}