Compute residual scale for SVGImage drawing using the integer size #29148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 28, 2021
The (rounded) integer size is used when sizing the underlying Frame(View), so we need to use it, rather than the LayoutSize, to compute the residual scale to avoid having the image 'spill' out of the viewport. This also improves the case in crbug.com/1123047 enough to call it fixed. Add a test for it. Bug: 1212634, 1163178, 1123047 Change-Id: I9ea8a7ae99ae195c755db036686f51a06f6ac59e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2916995 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#887717}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2916995
branch
from
a59c3fc
to
23a1cd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (rounded) integer size is used when sizing the underlying
Frame(View), so we need to use it, rather than the LayoutSize, to
compute the residual scale to avoid having the image 'spill' out of the
viewport.
This also improves the case in crbug.com/1123047 enough to call it
fixed. Add a test for it.
Bug: 1212634, 1163178, 1123047
Change-Id: I9ea8a7ae99ae195c755db036686f51a06f6ac59e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2916995
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#887717}