[GridNG] Do an additional pass when the min/max depends on block-size #29197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 3, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2936087
branch
from
b6ac62f
to
b85049c
Compare
As above. Previously legacy grid wasn't applying this rule directly, but if a grid was laid out twice, it'd use stale information to get the "correct" result on the 2nd layout pass. This fixed NG by explicity performing a 2nd pass. Added tests which quote the relevant part of the specification. Bug: 1045599, 1213878 Change-Id: Ia2e977356099642f3b6d1276bfcad0e201695541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2936087 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#889078}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2936087
branch
from
b85049c
to
050ac4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As above. Previously legacy grid wasn't applying this rule directly, but
if a grid was laid out twice, it'd use stale information to get the
"correct" result on the 2nd layout pass. This fixed NG by explicity
performing a 2nd pass. Added tests which quote the relevant part of the
specification.
Bug: 1045599, 1213878
Change-Id: Ia2e977356099642f3b6d1276bfcad0e201695541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2936087
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#889078}