[css-flex] Add support for newer css-align-3 keywords #29395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 16, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2959465
branch
2 times, most recently
from
221e18e
to
465f051
Compare
Specifically start, end, self-start, self-end, left, right
I used two chokepoints (ResolvedJustifyContent and AlignmentForChild) to
translate kSelfStart, kSelfEnd, kLeft, and kRight to
k{Flex}?[End|Start], which callers mostly already support.
AlignmentForChild also translates kStart and kEnd to kFlexStart and
kFlexEnd. But callers to ResolvedJustifyContent have to handle kStart
and kEnd on their own.
https://www.chromestatus.com/feature/5777880099323904
Bug: 1011718
Change-Id: Ic7ea9bfda9e3e11bcb622358b55dce9f6971cbe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2959465
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#895516}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2959465
branch
from
465f051
to
f03d1a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically start, end, self-start, self-end, left, right
I used two chokepoints (ResolvedJustifyContent and AlignmentForChild) to
translate kSelfStart, kSelfEnd, kLeft, and kRight to
k{Flex}?[End|Start], which callers mostly already support.
AlignmentForChild also translates kStart and kEnd to kFlexStart and
kFlexEnd. But callers to ResolvedJustifyContent have to handle kStart
and kEnd on their own.
https://www.chromestatus.com/feature/5777880099323904
Bug: 1011718
Change-Id: Ic7ea9bfda9e3e11bcb622358b55dce9f6971cbe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2959465
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#895516}