Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error if connections are made between different contexts #29400

Merged
merged 1 commit into from Jun 26, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 16, 2021

The WebAudio spec says that if a node is connected/disconnected to
another node or AudioParam that belongs to a different context, then
an InvalidStateError must be thrown.[1][2] Add a check for this and throw
the required error.

This also requires a fix to audit.js which wasn't properly catching
DOM exceptions of the wrong type.

Finally, ctor-channelsplitter.html needed to be updated to specify the
error type because of the change in audit.js.

Also adds new WPT test, different-contexts.html, to more thoroughly test
connect/disconnects to different contexts.

[1] https://webaudio.github.io/web-audio-api/#dom-audionode-connect-destinationnode-output-input-destinationnode
[2] https://webaudio.github.io/web-audio-api/#dom-audionode-disconnect-destinationnode-destinationnode

Bug: 1206927
Change-Id: I320425268d1fd243e347dd36c79172c69dcc9733
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2965479
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#895851}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2965479 branch 3 times, most recently from 001a1f9 to 743fd81 Compare June 22, 2021 15:06
The WebAudio spec says that if a node is connected/disconnected to
another node or AudioParam that belongs to a different context, then
an InvalidStateError must be thrown.[1][2]  Add a check for this and throw
the required error.

This also requires a fix to audit.js which wasn't properly catching
DOM exceptions of the wrong type.

Finally, ctor-channelsplitter.html needed to be updated to specify the
error type because of the change in audit.js.

Also adds new WPT test, different-contexts.html, to more thoroughly test
connect/disconnects to different contexts.

[1] https://webaudio.github.io/web-audio-api/#dom-audionode-connect-destinationnode-output-input-destinationnode
[2] https://webaudio.github.io/web-audio-api/#dom-audionode-disconnect-destinationnode-destinationnode

Bug: 1206927
Change-Id: I320425268d1fd243e347dd36c79172c69dcc9733
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2965479
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#895851}
@WeizhongX
Copy link
Contributor

See unstable results in Chrome

Unstable results

Test Subtest Results Messages
/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-output-channel-count.https.html The expected output channel count is equal to 17. PASS: 9/10, MISSING: 1/10  
/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-output-channel-count.https.html < [Dynamically change the channel count to if unspecified.] All assertions passed. (total 1 assertions) PASS: 9/10, MISSING: 1/10  
/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-output-channel-count.https.html # AUDIT TASK RUNNER FINISHED: 2 tasks ran successfully. PASS: 9/10, MISSING: 1/10  
/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-output-channel-count.https.html X The expected output channel count is not equal to 17. Got 1. FAIL: 1/10, MISSING: 9/10 assert_true: expected true got false
/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-output-channel-count.https.html < [Dynamically change the channel count to if unspecified.] 1 out of 1 assertions were failed. FAIL: 1/10, MISSING: 9/10 assert_true: expected true got false
/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-output-channel-count.https.html # AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed. FAIL: 1/10, MISSING: 9/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #0 is not constantly 0 (contains 39743 different values). PASS: 3/10, MISSING: 7/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #1 is not constantly 0 (contains 39745 different values). PASS: 3/10, MISSING: 7/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #2 is not constantly 0 (contains 39744 different values). PASS: 3/10, MISSING: 7/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #3 is not constantly 0 (contains 39744 different values). PASS: 3/10, MISSING: 7/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #0 is not constantly 0 (contains 41919 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #1 is not constantly 0 (contains 41921 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #2 is not constantly 0 (contains 41919 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #3 is not constantly 0 (contains 41920 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #0 is not constantly 0 (contains 42303 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #1 is not constantly 0 (contains 42305 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #2 is not constantly 0 (contains 42303 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #3 is not constantly 0 (contains 42304 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #0 is not constantly 0 (contains 40511 different values). PASS: 3/10, MISSING: 7/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #1 is not constantly 0 (contains 40513 different values). PASS: 3/10, MISSING: 7/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #2 is not constantly 0 (contains 40512 different values). PASS: 3/10, MISSING: 7/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #3 is not constantly 0 (contains 40512 different values). PASS: 3/10, MISSING: 7/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #0 is not constantly 0 (contains 40127 different values). PASS: 2/10, MISSING: 8/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #1 is not constantly 0 (contains 40129 different values). PASS: 2/10, MISSING: 8/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #2 is not constantly 0 (contains 40128 different values). PASS: 2/10, MISSING: 8/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #3 is not constantly 0 (contains 40128 different values). PASS: 2/10, MISSING: 8/10  

@WeizhongX
Copy link
Contributor

also see unstable results in Firefox

Unstable results

Test Subtest Results Messages
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #0 is not constantly 0 (contains 35903 different values). PASS: 2/10, MISSING: 8/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #1 is not constantly 0 (contains 35905 different values). PASS: 2/10, MISSING: 8/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #2 is not constantly 0 (contains 35904 different values). PASS: 2/10, MISSING: 8/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #3 is not constantly 0 (contains 35904 different values). PASS: 2/10, MISSING: 8/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #0 is not constantly 0 (contains 35263 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #1 is not constantly 0 (contains 35265 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #2 is not constantly 0 (contains 35264 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #3 is not constantly 0 (contains 35264 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #0 is not constantly 0 (contains 36287 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #1 is not constantly 0 (contains 36289 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #2 is not constantly 0 (contains 36288 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #3 is not constantly 0 (contains 36288 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #0 is not constantly 0 (contains 37311 different values). PASS: 2/10, MISSING: 8/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #1 is not constantly 0 (contains 37313 different values). PASS: 2/10, MISSING: 8/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #2 is not constantly 0 (contains 37312 different values). PASS: 2/10, MISSING: 8/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #3 is not constantly 0 (contains 37312 different values). PASS: 2/10, MISSING: 8/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #0 is not constantly 0 (contains 36927 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #1 is not constantly 0 (contains 36929 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #2 is not constantly 0 (contains 36928 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #3 is not constantly 0 (contains 36928 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #0 is not constantly 0 (contains 44095 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #1 is not constantly 0 (contains 44097 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #2 is not constantly 0 (contains 44095 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #3 is not constantly 0 (contains 44096 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #0 is not constantly 0 (contains 37823 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #1 is not constantly 0 (contains 37825 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #2 is not constantly 0 (contains 37824 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #3 is not constantly 0 (contains 37824 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #0 is not constantly 0 (contains 36799 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #1 is not constantly 0 (contains 36801 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #2 is not constantly 0 (contains 36800 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html Recorded channel #3 is not constantly 0 (contains 36800 different values). PASS: 1/10, MISSING: 9/10  
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #0: Expected 0 for all values but found 37951 unexpected values: \n\tIndex\tActual\n\t[6145]\t0.015655517578125\n\t[6146]\t0.031280517578125\n\t[6147]\t0.0467529296875\n\t[6148]\t0.06201171875\n\t...and 37947 more errors. FAIL: 1/10, MISSING: 9/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #1: Expected 0 for all values but found 37953 unexpected values: \n\tIndex\tActual\n\t[6145]\t0.015655517578125\n\t[6146]\t0.031280517578125\n\t[6147]\t0.046722412109375\n\t[6148]\t0.06201171875\n\t...and 37949 more errors. FAIL: 1/10, MISSING: 9/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #2: Expected 0 for all values but found 37952 unexpected values: \n\tIndex\tActual\n\t[6145]\t0.015655517578125\n\t[6146]\t0.031280517578125\n\t[6147]\t0.046722412109375\n\t[6148]\t0.062042236328125\n\t...and 37948 more errors. FAIL: 1/10, MISSING: 9/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #3: Expected 0 for all values but found 37952 unexpected values: \n\tIndex\tActual\n\t[6145]\t0.015655517578125\n\t[6146]\t0.031280517578125\n\t[6147]\t0.046722412109375\n\t[6148]\t0.06207275390625\n\t...and 37948 more errors. FAIL: 1/10, MISSING: 9/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #0: Expected 0 for all values but found 39103 unexpected values: \n\tIndex\tActual\n\t[4993]\t0.015655517578125\n\t[4994]\t0.031280517578125\n\t[4995]\t0.0467529296875\n\t[4996]\t0.06201171875\n\t...and 39099 more errors. FAIL: 1/10, MISSING: 9/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #1: Expected 0 for all values but found 39105 unexpected values: \n\tIndex\tActual\n\t[4993]\t0.015655517578125\n\t[4994]\t0.031280517578125\n\t[4995]\t0.046722412109375\n\t[4996]\t0.06201171875\n\t...and 39101 more errors. FAIL: 1/10, MISSING: 9/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #2: Expected 0 for all values but found 39104 unexpected values: \n\tIndex\tActual\n\t[4993]\t0.015655517578125\n\t[4994]\t0.031280517578125\n\t[4995]\t0.046722412109375\n\t[4996]\t0.062042236328125\n\t...and 39100 more errors. FAIL: 1/10, MISSING: 9/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #3: Expected 0 for all values but found 39104 unexpected values: \n\tIndex\tActual\n\t[4993]\t0.015655517578125\n\t[4994]\t0.031280517578125\n\t[4995]\t0.046722412109375\n\t[4996]\t0.06207275390625\n\t...and 39100 more errors. FAIL: 1/10, MISSING: 9/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #0: Expected 0 for all values but found 38207 unexpected values: \n\tIndex\tActual\n\t[5889]\t0.015655517578125\n\t[5890]\t0.031280517578125\n\t[5891]\t0.0467529296875\n\t[5892]\t0.06201171875\n\t...and 38203 more errors. FAIL: 5/10, MISSING: 5/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #1: Expected 0 for all values but found 38209 unexpected values: \n\tIndex\tActual\n\t[5889]\t0.015655517578125\n\t[5890]\t0.031280517578125\n\t[5891]\t0.046722412109375\n\t[5892]\t0.06201171875\n\t...and 38205 more errors. FAIL: 5/10, MISSING: 5/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #2: Expected 0 for all values but found 38208 unexpected values: \n\tIndex\tActual\n\t[5889]\t0.015655517578125\n\t[5890]\t0.031280517578125\n\t[5891]\t0.046722412109375\n\t[5892]\t0.062042236328125\n\t...and 38204 more errors. FAIL: 5/10, MISSING: 5/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #3: Expected 0 for all values but found 38208 unexpected values: \n\tIndex\tActual\n\t[5889]\t0.015655517578125\n\t[5890]\t0.031280517578125\n\t[5891]\t0.046722412109375\n\t[5892]\t0.06207275390625\n\t...and 38204 more errors. FAIL: 5/10, MISSING: 5/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #0: Expected 0 for all values but found 38591 unexpected values: \n\tIndex\tActual\n\t[5505]\t0.015655517578125\n\t[5506]\t0.031280517578125\n\t[5507]\t0.0467529296875\n\t[5508]\t0.06201171875\n\t...and 38587 more errors. FAIL: 2/10, MISSING: 8/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #1: Expected 0 for all values but found 38593 unexpected values: \n\tIndex\tActual\n\t[5505]\t0.015655517578125\n\t[5506]\t0.031280517578125\n\t[5507]\t0.046722412109375\n\t[5508]\t0.06201171875\n\t...and 38589 more errors. FAIL: 2/10, MISSING: 8/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #2: Expected 0 for all values but found 38592 unexpected values: \n\tIndex\tActual\n\t[5505]\t0.015655517578125\n\t[5506]\t0.031280517578125\n\t[5507]\t0.046722412109375\n\t[5508]\t0.062042236328125\n\t...and 38588 more errors. FAIL: 2/10, MISSING: 8/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #3: Expected 0 for all values but found 38592 unexpected values: \n\tIndex\tActual\n\t[5505]\t0.015655517578125\n\t[5506]\t0.031280517578125\n\t[5507]\t0.046722412109375\n\t[5508]\t0.06207275390625\n\t...and 38588 more errors. FAIL: 2/10, MISSING: 8/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #0: Expected 0 for all values but found 37311 unexpected values: \n\tIndex\tActual\n\t[6785]\t0.015655517578125\n\t[6786]\t0.031280517578125\n\t[6787]\t0.0467529296875\n\t[6788]\t0.06201171875\n\t...and 37307 more errors. FAIL: 1/10, MISSING: 9/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #1: Expected 0 for all values but found 37313 unexpected values: \n\tIndex\tActual\n\t[6785]\t0.015655517578125\n\t[6786]\t0.031280517578125\n\t[6787]\t0.046722412109375\n\t[6788]\t0.06201171875\n\t...and 37309 more errors. FAIL: 1/10, MISSING: 9/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #2: Expected 0 for all values but found 37312 unexpected values: \n\tIndex\tActual\n\t[6785]\t0.015655517578125\n\t[6786]\t0.031280517578125\n\t[6787]\t0.046722412109375\n\t[6788]\t0.062042236328125\n\t...and 37308 more errors. FAIL: 1/10, MISSING: 9/10 assert_true: expected true got false
/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html X Recorded channel #3: Expected 0 for all values but found 37312 unexpected values: \n\tIndex\tActual\n\t[6785]\t0.015655517578125\n\t[6786]\t0.031280517578125\n\t[6787]\t0.046722412109375\n\t[6788]\t0.06207275390625\n\t...and 37308 more errors. FAIL: 1/10, MISSING: 9/10 assert_true: expected true got false

@WeizhongX
Copy link
Contributor

Filed crbug.com/1223887, @foolip, @past can you admin merge it?

@foolip foolip merged commit c632c82 into master Jun 26, 2021
@foolip foolip deleted the chromium-export-cl-2965479 branch June 26, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants