New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw error if connections are made between different contexts #29400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2965479
branch
3 times, most recently
from
June 22, 2021 15:06
001a1f9
to
743fd81
Compare
The WebAudio spec says that if a node is connected/disconnected to another node or AudioParam that belongs to a different context, then an InvalidStateError must be thrown.[1][2] Add a check for this and throw the required error. This also requires a fix to audit.js which wasn't properly catching DOM exceptions of the wrong type. Finally, ctor-channelsplitter.html needed to be updated to specify the error type because of the change in audit.js. Also adds new WPT test, different-contexts.html, to more thoroughly test connect/disconnects to different contexts. [1] https://webaudio.github.io/web-audio-api/#dom-audionode-connect-destinationnode-output-input-destinationnode [2] https://webaudio.github.io/web-audio-api/#dom-audionode-disconnect-destinationnode-destinationnode Bug: 1206927 Change-Id: I320425268d1fd243e347dd36c79172c69dcc9733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2965479 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#895851}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2965479
branch
from
June 25, 2021 00:35
743fd81
to
28c6619
Compare
See unstable results in Chrome Unstable results
|
also see unstable results in Firefox Unstable results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WebAudio spec says that if a node is connected/disconnected to
another node or AudioParam that belongs to a different context, then
an InvalidStateError must be thrown.[1][2] Add a check for this and throw
the required error.
This also requires a fix to audit.js which wasn't properly catching
DOM exceptions of the wrong type.
Finally, ctor-channelsplitter.html needed to be updated to specify the
error type because of the change in audit.js.
Also adds new WPT test, different-contexts.html, to more thoroughly test
connect/disconnects to different contexts.
[1] https://webaudio.github.io/web-audio-api/#dom-audionode-connect-destinationnode-output-input-destinationnode
[2] https://webaudio.github.io/web-audio-api/#dom-audionode-disconnect-destinationnode-destinationnode
Bug: 1206927
Change-Id: I320425268d1fd243e347dd36c79172c69dcc9733
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2965479
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#895851}