Commits on Jun 17, 2021

1. Properly disallow custom layout + multicol. …

   Checking LayoutObject type won't do, since we don't always create a
   LayoutNGCustom object (e.g. if it's a DETAILS element (but, then again,
   should we allow custom layout on those???)). Check display type instead.
   
   The reason for the crash was that we ended up creating a
   LayoutNGBlockFragmentation multicol container inside a legacy multicol
   container, even when LayoutNGBlockFragmentation is disabled (custom
   layout forces LayoutNG). We don't create a paint layer on the flow
   thread (nor the multicol container) in LayoutNGBlockFragmentation, which
   the legacy pre-paint code assumes.
   
   Bug: 1219874
   Change-Id: I26fcd8d4a5fd51ce1799b207bf39b8e322890ca9
   Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2964675
   Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
   Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
   Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#893340}

   

   mstensho authored and chromium-wpt-export-bot committed Jun 17, 2021
   Copy the full SHA

   75e72ad View commit details

   Browse the repository at this point in the history