[Private Network Access] Add more web platform tests. #29525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 29, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2987794
branch
2 times, most recently
from
d87e779
to
3f6ae5f
Compare
This implements WPT RFC 72 support for the Blink web test runner. This draws on similar work done for wptrunner in the following WPT PR: #28870 That PR taught wptserve how to run servers for http(s)-{private,public} ports and configure Chrome to treat those ports as belonging to the `private` and `public` address spaces. This CL teaches the Blink web test runner to do the same, then adds some tests verifying that. Bug: chromium:1138904 Change-Id: I7c118b64d62ac6932988ad40e370b0d7c72b56b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2987794 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#896984}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2987794
branch
from
3f6ae5f
to
f194e3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements WPT RFC 72 support for the Blink web test runner. This
draws on similar work done for wptrunner in the following WPT PR:
#28870
That PR taught wptserve how to run servers for http(s)-{private,public}
ports and configure Chrome to treat those ports as belonging to the
privateandpublicaddress spaces. This CL teaches the Blink webtest runner to do the same, then adds some tests verifying that.
Bug: chromium:1138904
Change-Id: I7c118b64d62ac6932988ad40e370b0d7c72b56b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2987794
Commit-Queue: Titouan Rigoudy <titouan@chromium.org>
Auto-Submit: Titouan Rigoudy <titouan@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#896984}