Add AudioData::copyTo() #29629
Merged
Add AudioData::copyTo() #29629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 9, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3011779
branch
4 times, most recently
from
aec3025
to
5ca53c9
Compare
This CL updates AudioData according to the latest WebCodecs spec. It adds an allocationSize() and a copyTo() method to AudioData. WPTs will be included in future CLs, when AudioDataInit is updated to use a BufferSource instead of an AudioBuffer. Bug: 1205281 Change-Id: I97a2ed6ac094e373671262d3ba4089d150d94446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3011779 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#900655}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3011779
branch
from
5ca53c9
to
51383ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL updates AudioData according to the latest WebCodecs spec. It
adds an allocationSize() and a copyTo() method to AudioData.
WPTs will be included in future CLs, when AudioDataInit is updated to
use a BufferSource instead of an AudioBuffer.
Bug: 1205281
Change-Id: I97a2ed6ac094e373671262d3ba4089d150d94446
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3011779
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900655}