Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webcrypto: merge tentative BigInt test into main #29713

Merged
merged 1 commit into from Jul 20, 2021
Merged

Conversation

TimothyGu
Copy link
Member

The spec change got merged in w3c/webcrypto#266.

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@TimothyGu
Copy link
Member Author

CC @twiss

@sideshowbarker
Copy link
Contributor

Once @twiss OK’s this, I can rubberstamp-approve it (and merge it)

@sideshowbarker
Copy link
Contributor

I see now that although we have the WebCryptoAPI/META.yml file set up right:

spec: https://w3c.github.io/webcrypto/
suggested_reviewers:
- twiss

…I’d forgotten to add @twiss to the Reviewers team. Invited now, anyway — so the next time there’s a WPT WebCryptoAPI PR, this should all just work as expected.

Copy link
Member

@twiss twiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏
This looks good to me 👍

@sideshowbarker
Copy link
Contributor

@twiss do you have a merge button in the UI now? If so, please go ahead and push it…

@twiss
Copy link
Member

twiss commented Jul 20, 2021

Ah, yeah, now that you mention it, I do 😄

@twiss twiss merged commit cdd0f03 into master Jul 20, 2021
@twiss twiss deleted the TimothyGu/tentative branch July 20, 2021 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants