Revert "[fsa] Implement truncate for the sync access handle" #29762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7ddd6ce32e94379d5b7321b2de8ebde9e03c332c. Reason for revert: virtual/file-system-access-access-handle/external/wpt/file-system-access/sandboxed_FileSystemSyncAccessHandle-close.https.tentative.worker.html Started failing on: https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.13%20Tests/40088/overview Original change's description: > [fsa] Implement truncate for the sync access handle > > The implementation is ported from the implementation of > Storage Foundation in > https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/native_io/native_io_file_async.cc. > > This is part of the efforts to merge Storage Foundation into OPFS. > > Note that this CL does not contain the implementation for MacOS below > version 10.15. The old MacOS needs special handling, which will be added > in a separate CL. > > Bug: chromium:1218431 > Change-Id: I8e742fe0beeb93520e521358981f561a83c11732 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3044117 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#904693} Bug: chromium:1218431 Change-Id: Id8bd9fb310bdf0f38efb2860b87a985f650b617d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3048554 Auto-Submit: Henrik Boström <hbos@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Henrik Boström <hbos@google.com> Cr-Commit-Position: refs/heads/master@{#904728}
wpt-pr-bot
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7ddd6ce32e94379d5b7321b2de8ebde9e03c332c.
Reason for revert:
virtual/file-system-access-access-handle/external/wpt/file-system-access/sandboxed_FileSystemSyncAccessHandle-close.https.tentative.worker.html
Started failing on:
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.13%20Tests/40088/overview
Original change's description:
Bug: chromium:1218431
Change-Id: Id8bd9fb310bdf0f38efb2860b87a985f650b617d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3048554
Auto-Submit: Henrik Boström <hbos@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Henrik Boström <hbos@google.com>
Cr-Commit-Position: refs/heads/master@{#904728}