[Gecko Bug 1671527] Part 3 - Reparent floats when creating non-column-span wrapper frames. #29771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are in CreateColumnSpanSiblings(), there are floats in nsFrameConstructorState::mFloatedList that are waiting to be added to aInitialBlock once we leave scope of the float containing block. However, since we are creating non-column-span continuations, which are continuations of aInitialBlock, we should reparent the floats to these continuations if their placeholders are the descendants of the newly-created continuations. multicol-span-float-002.html exercises nsCSSFrameConstructor::ConstructBlock() and multicol-span-float-003.html exercises nsCSSFrameConstructor::CreateIBSiblings(). Without this patch, multicol-span-float-002.html and multicol-span-float-003.html still pass, but they trigger ``` ASSERTION: nsBlockFrame::CheckFloats: Explicit float list is out of sync with float cache ``` 1524382.html used to trigger the above assertions. Now it's fixed. Differential Revision: https://phabricator.services.mozilla.com/D120105 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1671527 gecko-commit: fa7249945de1f8adc586889a4c7fb1f89322a219 gecko-reviewers: emilio
wpt-pr-bot
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are in CreateColumnSpanSiblings(), there are floats in
nsFrameConstructorState::mFloatedList that are waiting to be added to
aInitialBlock once we leave scope of the float containing block.
However, since we are creating non-column-span continuations, which are
continuations of aInitialBlock, we should reparent the floats to these
continuations if their placeholders are the descendants of the
newly-created continuations.
multicol-span-float-002.html exercises
nsCSSFrameConstructor::ConstructBlock() and multicol-span-float-003.html
exercises nsCSSFrameConstructor::CreateIBSiblings().
Without this patch, multicol-span-float-002.html and
multicol-span-float-003.html still pass, but they trigger
1524382.html used to trigger the above assertions. Now it's fixed.
Differential Revision: https://phabricator.services.mozilla.com/D120105
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1671527
gecko-commit: fa7249945de1f8adc586889a4c7fb1f89322a219
gecko-reviewers: emilio