Rename Canvas2D.textWordSpacing to Canvas2D.wordSpacing #29821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 28, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3056391
branch
2 times, most recently
from
a7eaecf
to
d823be4
Compare
Per discussion in w3ctag/design-reviews#627, we have agreed to remove text prefix for attribute textWordSpacing. So that thee attribute name wordSpacing follows the same naming conversion of other text attributes. Bug: 1233706 Change-Id: Ic735c7c4617572511fd37fe0928f8919e7fd3f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3056391 Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#906470}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3056391
branch
from
d823be4
to
fc69a50
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in w3ctag/design-reviews#627,
we have agreed to remove text prefix for attribute textWordSpacing. So
that thee attribute name wordSpacing follows the same naming conversion
of other text attributes.
Bug: 1233706
Change-Id: Ic735c7c4617572511fd37fe0928f8919e7fd3f69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3056391
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#906470}