[CSP] Fix WPT eval-blocked-in-about-blank-iframe #29836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 29, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3059564
branch
from
20d4178
to
d8b1346
Compare
The test was failing for all vendors since it expected to get a securitypolicyviolation event in the parent frame instead of the frame where the eval was blocked. I rewrote the test in a modern way and deleted the old http blink test this one had been converted from. Bug: 651742 Change-Id: Ie8b7ae4842c0934b3c18086a2aee93c8a8ca292a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3059564 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#906671}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3059564
branch
from
d8b1346
to
45d4cb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was failing for all vendors since it expected to get a
securitypolicyviolation event in the parent frame instead of the frame
where the eval was blocked.
I rewrote the test in a modern way and deleted the old http blink test
this one had been converted from.
Bug: 651742
Change-Id: Ie8b7ae4842c0934b3c18086a2aee93c8a8ca292a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3059564
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#906671}