[WebCodecs] Revert workarounds for lack of [AllowShared] in IDL. #29854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 30, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3064085
branch
5 times, most recently
from
5b40eb3
to
2dd4627
Compare
This is fixed now, so enable tests and revert workarounds. This is
mostly a pure revert of video_frame.{cc,h,idl} since no other
changes have landed since the workaround.
We can't use "[AllowShared] BufferSource" since [AllowShared] still
isn't allowed with a union type, so we need to explicitly write out:
"([AllowShared] ArrayBuffer or [AllowShared] ArrayBufferView) "
The OWNERS for DOMArrayPiece don't want to add SharedArrayBuffer
support at this time, so DOMArrayPiece usage has been replaced
with a custom AsSpan<>() mechanism.
R=sandersd
Fixed: 1088107
Change-Id: I0bfa0339089cea80c9dc5a7856b5c8707a3e5005
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3064085
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909184}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3064085
branch
from
2dd4627
to
3e854cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixed now, so enable tests and revert workarounds. This is
mostly a pure revert of video_frame.{cc,h,idl} since no other
changes have landed since the workaround.
We can't use "[AllowShared] BufferSource" since [AllowShared] still
isn't allowed with a union type, so we need to explicitly write out:
"([AllowShared] ArrayBuffer or [AllowShared] ArrayBufferView) "
The OWNERS for DOMArrayPiece don't want to add SharedArrayBuffer
support at this time, so DOMArrayPiece usage has been replaced
with a custom AsSpan<>() mechanism.
R=sandersd
Fixed: 1088107
Change-Id: I0bfa0339089cea80c9dc5a7856b5c8707a3e5005
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3064085
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909184}