[mathml] Use embellished operator properties for underover gaps #29893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 4, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3071438
branch
2 times, most recently
from
57ca6ac
to
2b0470b
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3071438
branch
from
2b0470b
to
6fe58d6
Compare
The MathML Core spec [1] [2] contains the following cases for underover layout: 1. The base is an embellished operator with the largeop property. 2. The base is an embellished operator with the stretchy property and stretch axis inline. Currently, the underover algorithm only checks if the base is an <mo> element. This CL modifies to instead check whether it is an embellished operators and if that's the case retrieve these properties from the core operator. New WPT tests are added to cover the changes from this CL: - underover-parameters-and-embellished-operator-1.html is a copy of underover-parameters-and-operator-1.html with <mo> embellished with an <mrow>. It checks (1) above. - underover-parameters-and-embellished-operator-2.html is a copy of underover-parameters-and-operator-2.html with <mo> embellished with an <mrow>. It checks (2) above. [1] https://w3c.github.io/mathml-core/#base-with-underscript [2] https://w3c.github.io/mathml-core/#base-with-overscript Bug: 6606, 1124298 Change-Id: I2f30ed19cceacb7e2fbd70f83e2e81af9b0537c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3071438 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#915528}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3071438
branch
from
6fe58d6
to
b0e2790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MathML Core spec [1] [2] contains the following cases for
underover layout:
and stretch axis inline.
Currently, the underover algorithm only checks if the base is
an <mo> element. This CL modifies to instead check whether it is
an embellished operators and if that's the case retrieve these
properties from the core operator.
New WPT tests are added to cover the changes from this CL:
of underover-parameters-and-operator-1.html with <mo>
embellished with an <mrow>. It checks (1) above.
of underover-parameters-and-operator-2.html with <mo>
embellished with an <mrow>. It checks (2) above.
[1] https://w3c.github.io/mathml-core/#base-with-underscript
[2] https://w3c.github.io/mathml-core/#base-with-overscript
Bug: 6606, 1124298
Change-Id: I2f30ed19cceacb7e2fbd70f83e2e81af9b0537c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3071438
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#915528}