Fix 2d-getcontext-options.html test #29919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 5, 2021
The test called getContext('2d', options) twice, so all the options got
added twice to actual object. The expected value doesn't take into
account of the second run. I added a reset for actual after the first
getContext.
Bug: 1233656
Change-Id: Ib0295ba41131e778e15ac1d23719faf8f1c0dbd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3075720
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909033}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3075720
branch
from
7393a0b
to
2089079
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test called getContext('2d', options) twice, so all the options got
added twice to actual object. The expected value doesn't take into
account of the second run. I added a reset for actual after the first
getContext.
Bug: 1233656
Change-Id: Ib0295ba41131e778e15ac1d23719faf8f1c0dbd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3075720
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909033}