Reland "Populate pointerId, pointerType for contextmenu event" #30065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 18, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3101585
branch
from
8e03bbe
to
3e38085
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3101585
branch
4 times, most recently
from
194623e
to
94f8b88
Compare
This is a reland of a6d69d5243dd02afbd8ef02e5a5c557dd8c4a9e9 I believe the reason for the test failures when this landed the first time was related to how pointerId was populated for the contextmenu pointer event. With crrev.com/c/2889205 landed, we have a robust way to associate the gesture event sequence with the corresponding pointer event sequence. This CL uses the approach in crrev.com/c/2889205 to populate the pointerId for the contextmenu pointer event. Original change's description: > Populate pointerId, pointerType for contextmenu event > > For contextmenu as a pointer event pointerId and pointerType > were not populated. > > In this CL we are populating pointerId/pointerType for contextmenu > coming from touch and mouse. > For touch we use a similar approach to crrev.com/c/2800231 > for populating pointerId,pointerType for clicks generated in > GestureManager::HandleGestureTap. > The main change will be in EventHandler::SendContextMenuEvent > where we'll be passing id and pointer type to the call to > MouseEventManager::DispatchMouseEvent. This in turn will > populate pointerId and pointerType correctly when the contextmenu > PointerEvent is created. > > Bug: 1150442,1150441 > TEST: external/wpt/pointerevents/pointerevent_contextmenu_is_a_pointerevent.html > Change-Id: If2408d9cf0d5f00b08efcf2236ff7933472972ce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2874026 > Commit-Queue: Liviu Tinta <liviutinta@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#881145} Bug: 1150442,1150441,1207709 Change-Id: Iffaa60373a3811a10f54ff123e64850801450883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3101585 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#916130}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3101585
branch
from
94f8b88
to
bff8e8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of a6d69d5243dd02afbd8ef02e5a5c557dd8c4a9e9
I believe the reason for the test failures when this landed
the first time was related to how pointerId was populated
for the contextmenu pointer event.
With crrev.com/c/2889205 landed, we have a robust way to
associate the gesture event sequence with the corresponding
pointer event sequence.
This CL uses the approach in crrev.com/c/2889205 to populate
the pointerId for the contextmenu pointer event.
Original change's description:
Bug: 1150442,1150441,1207709
Change-Id: Iffaa60373a3811a10f54ff123e64850801450883
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3101585
Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#916130}