[block-in-inline] Support line-clamping correctly. #30115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 20, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3111327
branch
4 times, most recently
from
68944b8
to
75b97bb
Compare
To do this we always set the correct "lines-util-clamp" on the layout result, and just read that within the block-layout-algorithm. For non block-in-inline layout there should be no behaviour change. Bug: 716930 Change-Id: Ib8fc361f356943f385becd7503fa152d1f0f091d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111327 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#914520}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3111327
branch
from
75b97bb
to
78754a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do this we always set the correct "lines-util-clamp" on the layout
result, and just read that within the block-layout-algorithm.
For non block-in-inline layout there should be no behaviour change.
Bug: 716930
Change-Id: Ib8fc361f356943f385becd7503fa152d1f0f091d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111327
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#914520}