FS: Add check for removal of sandbox root dir #30261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 31, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3123735
branch
2 times, most recently
from
75dd5db
to
a1af0f4
Compare
The FileSystemHandle::Remove() method was recently added to allow for the removal of files and directories from the underlying file system. This method now fails when attempting to delete the root of a sandbox file system. Bug: 1242231 Change-Id: Ibe3ed59b79678ce168d0803c6607abd8ac06594c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3123735 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/main@{#917845}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3123735
branch
from
a1af0f4
to
1bd5015
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FileSystemHandle::Remove() method was recently added to allow for
the removal of files and directories from the underlying file system.
This method now fails when attempting to delete the root of a sandbox
file system.
Bug: 1242231
Change-Id: Ibe3ed59b79678ce168d0803c6607abd8ac06594c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3123735
Commit-Queue: Austin Sullivan <asully@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917845}