Add CONNECT response WPTs for WebTransport #30282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 1, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3134980
branch
8 times, most recently
from
3924bd3
to
a6c46d1
Compare
This CL adds 7 test cases: - establish WebTransport connection with different status codes - echo the CONNECT request headers - setting a cookie in a CONNECT request, and then making sure the "cookie" header is not echoed back The echo-request-headers server handler is also added in this CL, which sends the CONNECT request headers over a unidirectional stream. Bug: 1201569 Change-Id: I30d8092af42dc2505cadbc15bf0573f8815758bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3134980 Commit-Queue: Nidhi Jaju <nidhijaju@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/main@{#918651}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3134980
branch
from
a6c46d1
to
23fa10b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds 7 test cases:
"cookie" header is not echoed back
The echo-request-headers server handler is also added in this CL, which
sends the CONNECT request headers over a unidirectional stream.
Bug: 1201569
Change-Id: I30d8092af42dc2505cadbc15bf0573f8815758bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3134980
Commit-Queue: Nidhi Jaju <nidhijaju@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#918651}