Add test for ImageCapture.takePhoto() setOptions failure #30293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 1, 2021
This change is a follow-up to crrev.com/c/3132384 which adds a new Web Platform Test that reproduces the issue by calling takePhoto() on a stream which doesn't provide PhotoCapabilities. Bug: 1229991 Change-Id: I685c587915587edf2573e182658d84de637171e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138862 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/main@{#917528}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3138862
branch
from
80601a4
to
97c93db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a follow-up to crrev.com/c/3132384 which adds a new Web
Platform Test that reproduces the issue by calling takePhoto() on a
stream which doesn't provide PhotoCapabilities.
Bug: 1229991
Change-Id: I685c587915587edf2573e182658d84de637171e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138862
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917528}