[WebCodecs] Prevent deeply nested frames. #30319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 2, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3140495
branch
from
8e2e2d1
to
205fb4a
Compare
It's not correct to directly access the wrapped frame since it may itself be wrapping another frame. Prevent nesting, but also switch call sites to not operate directly on |wrapped_frame_| for ease of reasoning. R=sandersd Fixed: 1246173 Change-Id: I1475aa695a1801620eebdcb88a0d421652696261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3140495 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/main@{#917938}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3140495
branch
from
205fb4a
to
6c55535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not correct to directly access the wrapped frame since it may
itself be wrapping another frame. Prevent nesting, but also switch
call sites to not operate directly on |wrapped_frame_| for ease of
reasoning.
R=sandersd
Fixed: 1246173
Change-Id: I1475aa695a1801620eebdcb88a0d421652696261
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3140495
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917938}