[Storage Access API] Fix anomalous behavior with tests that use iframes #30320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreubotella
force-pushed
the
andreubotella/storage-access-iframe-fix
branch
from
f1fbdc5
to
ff35315
Compare
The tests for `hasStorageAccess` and `requestStorageAccess` need to test in different browsing contexts, with different relationships to the top-level browsing context, and both same-origin and cross-origin. They do this by declaring tests in the test file, and then loading that same test file in iframes using `fetch_tests_from_window`. However, a requirement of `fetch_tests_from_window` is that the window whose tests to fetch must not include `testharnessreport.js` – which isn't true for these Storage Access API tests. While this doesn't seem to make a difference when running `wpt serve` or otherwise when using the default `testharnessreport.js` file, tests run with `wpt run` might timeout, and the subtests coming from the iframes might not be reported. This change creates versions of `hasStorageAccess.sub.window.html` and `requestStorageAccess.sub.window.html` that don't import `testharnessreport.js`, specifically to be loaded as iframes.
andreubotella
force-pushed
the
andreubotella/storage-access-iframe-fix
branch
from
ff35315
to
e5acd77
Compare
|
When running on my machine with |
Brandr0id
approved these changes
Sep 17, 2021
|
@andreubotella is this change ready to be merged? |
As I mentioned above, I was getting different results on CI than with |
|
The results do match this time, so I guess this can be merged now. |
|
Great! Let's merge, and I also have a Chromium bug tracking flakiness with these tests. Once this change hits the repo I'll confirm/investigate any remaining issues. Thanks again for the patch. |
Gabisampaio
pushed a commit
to Gabisampaio/wpt
that referenced
this pull request
Nov 18, 2021
…es (web-platform-tests#30320) The tests for `hasStorageAccess` and `requestStorageAccess` need to test in different browsing contexts, with different relationships to the top-level browsing context, and both same-origin and cross-origin. They do this by declaring tests in the test file, and then loading that same test file in iframes using `fetch_tests_from_window`. However, a requirement of `fetch_tests_from_window` is that the window whose tests to fetch must not include `testharnessreport.js` – which isn't true for these Storage Access API tests. While this doesn't seem to make a difference when running `wpt serve` or otherwise when using the default `testharnessreport.js` file, tests run with `wpt run` might timeout, and the subtests coming from the iframes might not be reported. This change creates versions of `hasStorageAccess.sub.window.html` and `requestStorageAccess.sub.window.html` that don't import `testharnessreport.js`, specifically to be loaded as iframes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for
hasStorageAccessandrequestStorageAccessneed to test in different browsing contexts, with different relationships to the top-level browsing context, and both same-origin and cross-origin. They do this by declaring tests in the test file, and then loading that same test file in iframes usingfetch_tests_from_window.However, a requirement of
fetch_tests_from_windowis that the window whose tests to fetch must not includetestharnessreport.js– which isn't true for these Storage Access API tests. While this doesn't seem to make a difference when runningwpt serveor otherwise when using the defaulttestharnessreport.jsfile, tests run withwpt runmight timeout, and the subtests coming from the iframes might not be reported.This change creates versions of
hasStorageAccess.sub.window.htmlandrequestStorageAccess.sub.window.htmlthat don't importtestharnessreport.js, specifically to be loaded as iframes.