[block-in-inline] Propagate baselines from block-in-inline #30402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 8, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3149290
branch
from
30848ee
to
e6b17ea
Compare
Block-in-inline is the only case where a line box may have different and optional first and last baselines. This patch propagtes them from block-in-inline correctly. Bug: 716930 Change-Id: I4eab225c7456ca31542a0187cb818568abafdb15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3149290 Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#919385}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3149290
branch
from
e6b17ea
to
00d76dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block-in-inline is the only case where a line box may have
different and optional first and last baselines.
This patch propagtes them from block-in-inline correctly.
Bug: 716930
Change-Id: I4eab225c7456ca31542a0187cb818568abafdb15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3149290
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#919385}